Content Shell: Move ShellMessageFilter to LayoutTestMessageFilter.

Content Shell: Move ShellMessageFilter to LayoutTestMessageFilter.

This message filter is only being used when running layout tests.

BUG=420994
R=mkwst@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/e8f2f9d9a92dea5aee7667b0b4fcb844ffc06ffa

[Peter Beverloo, 2014-10-16 15:31:14]

peter@chromium.org changed reviewers:
+ mkwst@chromium.org

[Peter Beverloo, 2014-10-16 15:31:15]

This depends on https://codereview.chromium.org/639293005/.

I also had to use --bypass-hooks because of
LayoutTestMessageFilter::OnReadFileToString using ScopedAllowIO. Changing that
is out of scope for this patch.

[Mike West, 2014-10-16 19:42:32]

This looks pretty reasonable. Once the other patch lands, let's see what the
bots say. Please run *_blink_rel as well to verify the behavior for layout
tests.

https://codereview.chromium.org/659073004/diff/1/content/shell/browser/layout...
File content/shell/browser/layout_test/layout_test_content_browser_client.cc
(right):

https://codereview.chromium.org/659073004/diff/1/content/shell/browser/layout...
content/shell/browser/layout_test/layout_test_content_browser_client.cc:72:
host->Send(new ShellViewMsg_SetWebKitSourceDir(GetWebKitRootDirFilePath()));
Nit: We should totally rename these to Blink at some point in the future.

[Peter Beverloo, 2014-10-17 11:07:43]

https://codereview.chromium.org/659073004/diff/1/content/shell/browser/layout...
File content/shell/browser/layout_test/layout_test_content_browser_client.cc
(right):

https://codereview.chromium.org/659073004/diff/1/content/shell/browser/layout...
content/shell/browser/layout_test/layout_test_content_browser_client.cc:72:
host->Send(new ShellViewMsg_SetWebKitSourceDir(GetWebKitRootDirFilePath()));
On 2014/10/16 19:42:32, Mike West wrote:
> Nit: We should totally rename these to Blink at some point in the future.

Agreed, but I'd prefer to avoid changing logic/naming in changes which just move
a bunch of code around. I'll follow up.

[Peter Beverloo, 2014-10-17 14:48:56]

On 2014/10/17 11:07:43, Peter Beverloo wrote:
>
https://codereview.chromium.org/659073004/diff/1/content/shell/browser/layout...
> File content/shell/browser/layout_test/layout_test_content_browser_client.cc
> (right):
> 
>
https://codereview.chromium.org/659073004/diff/1/content/shell/browser/layout...
> content/shell/browser/layout_test/layout_test_content_browser_client.cc:72:
> host->Send(new ShellViewMsg_SetWebKitSourceDir(GetWebKitRootDirFilePath()));
> On 2014/10/16 19:42:32, Mike West wrote:
> > Nit: We should totally rename these to Blink at some point in the future.
> 
> Agreed, but I'd prefer to avoid changing logic/naming in changes which just
move
> a bunch of code around. I'll follow up.

Mike: PTAL

[Mike West, 2014-10-17 15:00:21]

LGTM, thanks!

[Peter Beverloo, 2014-10-20 12:32:25]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-10-20 12:33:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/659073004/40001

[commit-bot: I haz the power, 2014-10-20 12:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 12:38:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Beverloo, 2014-10-20 12:53:14]

On 2014/10/20 12:38:27, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Muh. I'll wait until the last try-bots are happy and then I'll land manually.

[commit-bot: I haz the power, 2014-10-20 16:49:28]

Patchset 4 (id:??) landed as
https://crrev.com/e8f2f9d9a92dea5aee7667b0b4fcb844ffc06ffa
Cr-Commit-Position: refs/heads/master@{#300278}

[Peter Beverloo, 2014-10-20 16:49:30]

Committed patchset #4 (id:60001) manually as
e8f2f9d9a92dea5aee7667b0b4fcb844ffc06ffa.