Issue 659073002: Revert of RELEASE_ASSERT if last resort fallback font cannot be loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 659073002: Revert of RELEASE_ASSERT if last resort fallback font cannot be loaded. (Closed)

Created:
6 years, 2 months ago by jbroman

Modified:
6 years, 2 months ago

Reviewers:
eae

CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of RELEASE_ASSERT if last resort fallback font cannot be loaded. (patchset #1 id:1 of https://codereview.chromium.org/641763003/) Reason for revert: Reverting per request. https://code.google.com/p/chromium/issues/detail?id=421370#c11 Original issue's description: > RELEASE_ASSERT if last resort fallback font cannot be loaded. > > This will help confirm the suspicion that a number of ClusterFuzz reports > from constructTextRun are a result of this failing. There's probably nothing > useful that can be done with a font that lacks any font data anyhow. > > BUG=421370 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183470 TBR=eae@chromium.org NOTREECHECKS=true NOTRY=true BUG=421370, 423643 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183815