White list of users is updated on show. Supervised users not present on the device are removed.

White list of users is updated on show. Supervised users not present on the device are removed.

BUG=394771, 396628
Committed: https://crrev.com/d2eb100ad87b11331d3c802105cdcfbdafb1bc7f
Cr-Commit-Position: refs/heads/master@{#300093}

[merkulova, 2014-10-16 13:24:24]

merkulova@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Nikita (slow), 2014-10-16 17:36:51]

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
(left):

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:124:
DCHECK(args && args->empty());
I think this DCHECK should stay since argument list is supposed to be empty.

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
(right):

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:29: 
nit: drop this line

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:138: //
Remove supervised users if they're not present on the device;
Not clear from the code where exactly do you check that supervised user is not
present on the device.

nit: dot at the end

[merkulova, 2014-10-17 07:56:09]

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
(left):

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:124:
DCHECK(args && args->empty());
On 2014/10/16 17:36:51, Nikita Kostylev wrote:
> I think this DCHECK should stay since argument list is supposed to be empty.

Done.

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
(right):

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:29: 
On 2014/10/16 17:36:51, Nikita Kostylev wrote:
> nit: drop this line

Done.

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:138: //
Remove supervised users if they're not present on the device;
On 2014/10/16 17:36:51, Nikita Kostylev wrote:
> Not clear from the code where exactly do you check that supervised user is not
> present on the device.
> 
> nit: dot at the end

Done.

[Nikita (slow), 2014-10-17 11:05:11]

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
(right):

https://codereview.chromium.org/659063002/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc:138: //
Remove supervised users if they're not present on the device;
On 2014/10/17 07:56:08, merkulova wrote:
> On 2014/10/16 17:36:51, Nikita Kostylev wrote:
> > Not clear from the code where exactly do you check that supervised user is
not
> > present on the device.
> > 
> > nit: dot at the end
> 
> Done.

Still it's not quite clear why supervised users needs that kind of special
treatment. How are regular users different?
What happens if you remove regular user from login UI (that is part of
whitelist). When exactly would that user be removed?

[merkulova, 2014-10-17 12:05:15]

Discussed offline.

[Nikita (slow), 2014-10-17 12:06:40]

lgtm

[merkulova, 2014-10-17 12:06:55]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-10-17 12:07:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/659063002/40001

[commit-bot: I haz the power, 2014-10-17 12:57:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-17 12:57:46]

Patchset 3 (id:??) landed as
https://crrev.com/d2eb100ad87b11331d3c802105cdcfbdafb1bc7f
Cr-Commit-Position: refs/heads/master@{#300093}