Implement the ability to layout test Web Worker-based Notifications.

content/shell/browser/layout_test/layout_test_content_browser_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/layout_test/layout_test_content_browser_client.h"
 
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/storage_partition.h"
@@ skipping 17 matching lines @@
   if (manager)
     manager->RequestPermission(source_origin, callback);
   else
     callback.Run(blink::WebNotificationPermissionAllowed);
 }
 
 }  // namespace
 
 LayoutTestContentBrowserClient::LayoutTestContentBrowserClient() {
   DCHECK(!g_layout_test_browser_client);
+
+  layout_test_notification_manager_.reset(

[Mike West, 2014/10/23 19:05:35]

This drops the thread assertion you used to have. Is that intentional?

[Peter Beverloo, 2014/10/24 11:32:06]

Yes. The LayoutTestNotificationManager can now be accessed on the IO thread and
the UI thread depending on the interaction (to match the notification system
living in //chrome). Per-method asserts have been added there.

+      new LayoutTestNotificationManager());
+
   g_layout_test_browser_client = this;
 }
 
 LayoutTestContentBrowserClient::~LayoutTestContentBrowserClient() {
   g_layout_test_browser_client = nullptr;
 }
 
 LayoutTestContentBrowserClient* LayoutTestContentBrowserClient::Get() {
   return g_layout_test_browser_client;
 }
 
 LayoutTestNotificationManager*
 LayoutTestContentBrowserClient::GetLayoutTestNotificationManager() {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-  if (!layout_test_notification_manager_) {
-    layout_test_notification_manager_.reset(
-        new LayoutTestNotificationManager());
-  }
-
   return layout_test_notification_manager_.get();
 }
 
 void LayoutTestContentBrowserClient::RenderProcessWillLaunch(
     RenderProcessHost* host) {
   ShellContentBrowserClient::RenderProcessWillLaunch(host);
 
   StoragePartition* partition =
       BrowserContext::GetDefaultStoragePartition(browser_context());
   host->AddFilter(new LayoutTestMessageFilter(
@@ skipping 23 matching lines @@
     const GURL& source_url,
     ResourceContext* context,
     int render_process_id) {
   LayoutTestNotificationManager* manager = GetLayoutTestNotificationManager();
   if (manager)
     return manager->CheckPermission(source_url);
 
   return blink::WebNotificationPermissionAllowed;
 }
 
+void LayoutTestContentBrowserClient::ShowDesktopNotification(
+    const ShowDesktopNotificationHostMsgParams& params,
+    RenderFrameHost* render_frame_host,
+    scoped_ptr<DesktopNotificationDelegate> delegate,
+    base::Closure* cancel_callback) {
+  LayoutTestNotificationManager* manager = GetLayoutTestNotificationManager();

[Mike West, 2014/10/23 19:05:35]

Nit: This probably fits on one line as `if (LayoutTestNotificationManager ...)`

[Peter Beverloo, 2014/10/24 11:32:06]

No, it doesn't, but it does when using auto \o/.

+  if (manager)
+    manager->Show(params, delegate.Pass(), cancel_callback);
+}
+
 }  // namespace content