Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659043002: DevTools: fix styles for glasspane (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: fix styles for glasspane The glasspane should be a component-root so that it inherits all the basic styling. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183813

Patch Set 1 #

Patch Set 2 : address comments #

Patch Set 3 : address comments one more time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/devtools/front_end/ui/Dialog.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/ui/SoftContextMenu.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
lushnikov
PTAL
6 years, 2 months ago (2014-10-16 11:53:37 UTC) #1
pfeldman
lgtm
6 years, 2 months ago (2014-10-16 11:55:39 UTC) #2
pfeldman
You should add it into Dialog though.
6 years, 2 months ago (2014-10-16 11:56:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659043002/40001
6 years, 2 months ago (2014-10-16 12:14:47 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 183813
6 years, 2 months ago (2014-10-16 13:18:08 UTC) #6
apavlov
6 years, 2 months ago (2014-10-17 09:36:08 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/643773003/ by apavlov@chromium.org.

The reason for reverting is: A better solution has been landed in
https://src.chromium.org/viewvc/blink?view=rev&revision=183868.

Powered by Google App Engine
This is Rietveld 408576698