Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 659023002: Test plugin: fflush(stdout) after writing to stdout. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Test plugin: fflush(stdout) after writing to stdout. BUG=363099, 371084 Committed: https://crrev.com/243100c408f479f1deb7f318b49032f8be5c9cf9 Cr-Commit-Position: refs/heads/master@{#299870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/shell/tools/plugin/main.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Tested that this works locally (and other code that uses printf also calls fflush).
6 years, 2 months ago (2014-10-16 08:41:01 UTC) #2
Mike West
LGTM, thanks for tracking this down.
6 years, 2 months ago (2014-10-16 08:43:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659023002/1
6 years, 2 months ago (2014-10-16 08:45:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 09:16:50 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 09:17:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/243100c408f479f1deb7f318b49032f8be5c9cf9
Cr-Commit-Position: refs/heads/master@{#299870}

Powered by Google App Engine
This is Rietveld 408576698