Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659003002: annotatedInvalidationRects should be in format x,y,w,h (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
haraken, Xianzhu
CC:
blink-reviews, danakj, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, blink-layers+watch_chromium.org, Rik, Stephen Chennney, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

annotatedInvalidationRects should be in format x,y,w,h This fixes the FrameViewer json serialization of annotatedInvalidationRects. This CL fixes the format from (x, y, maxX, maxY) to (x, y, width, height). BUG=402033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183829

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix annotatedRects not LayoutRects #

Patch Set 3 : fix annotatedRects not LayoutRects #

Patch Set 4 : fix annotatedRects not LayoutRects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/graphics/GraphicsLayerDebugInfo.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
kouhei (in TOK)
wangxianzhu: Thanks for the bug report! PTAL.
6 years, 2 months ago (2014-10-16 04:19:00 UTC) #2
haraken
LGTM but wang should confirm.
6 years, 2 months ago (2014-10-16 04:27:38 UTC) #3
Xianzhu
https://codereview.chromium.org/659003002/diff/1/Source/platform/graphics/GraphicsLayerDebugInfo.cpp File Source/platform/graphics/GraphicsLayerDebugInfo.cpp (right): https://codereview.chromium.org/659003002/diff/1/Source/platform/graphics/GraphicsLayerDebugInfo.cpp#newcode87 Source/platform/graphics/GraphicsLayerDebugInfo.cpp:87: rectArray->pushNumber(rect.maxY()); Should these be also width and height? What ...
6 years, 2 months ago (2014-10-16 15:48:52 UTC) #4
kouhei (in TOK)
On 2014/10/16 15:48:52, Xianzhu wrote: > https://codereview.chromium.org/659003002/diff/1/Source/platform/graphics/GraphicsLayerDebugInfo.cpp > File Source/platform/graphics/GraphicsLayerDebugInfo.cpp (right): > > https://codereview.chromium.org/659003002/diff/1/Source/platform/graphics/GraphicsLayerDebugInfo.cpp#newcode87 > ...
6 years, 2 months ago (2014-10-16 16:28:39 UTC) #5
Xianzhu
On 2014/10/16 16:28:39, kouhei wrote: > On 2014/10/16 15:48:52, Xianzhu wrote: > > > https://codereview.chromium.org/659003002/diff/1/Source/platform/graphics/GraphicsLayerDebugInfo.cpp ...
6 years, 2 months ago (2014-10-16 16:44:09 UTC) #6
kouhei (in TOK)
Thanks! > I think we should make rect representations in this file consistent in later ...
6 years, 2 months ago (2014-10-16 16:50:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659003002/60001
6 years, 2 months ago (2014-10-16 16:51:22 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 17:30:50 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 183829

Powered by Google App Engine
This is Rietveld 408576698