Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 658993002: Convert ARRAYSIZE_UNSAFE -> arraysize in components/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+watchlist_chromium.org, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, tfarina, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert ARRAYSIZE_UNSAFE -> arraysize in components/. BUG=423134 Committed: https://crrev.com/37a447b86b8ac98c5827701e765de9558c6c50e7 Cr-Commit-Position: refs/heads/master@{#299934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -119 lines) Patch
M components/autofill/content/browser/wallet/wallet_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_regexes_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/contact_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_number_i18n_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_index_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_params_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M components/metrics/metrics_hashes_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/autocomplete_input_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/omnibox/autocomplete_match_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/autocomplete_result_unittest.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M components/omnibox/keyword_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store_default_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/psl_matching_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/schema.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/schema_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/query_parser/query_parser_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/query_parser/snippet_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_fetcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/search_engines/template_url_service_sync_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/search_engines/template_url_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/search_engines/template_url_unittest.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M components/signin/core/browser/signin_error_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/url_matcher/url_matcher_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/metrics_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/study_filtering_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M components/variations/variations_http_header_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
viettrungluu
6 years, 2 months ago (2014-10-16 04:13:45 UTC) #1
viettrungluu
(adding another owner to review, though obviously only one review is needed)
6 years, 2 months ago (2014-10-16 17:36:14 UTC) #3
erikwright (departed)
LGTM
6 years, 2 months ago (2014-10-16 17:44:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658993002/1
6 years, 2 months ago (2014-10-16 17:49:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 18:23:48 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 18:25:01 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/37a447b86b8ac98c5827701e765de9558c6c50e7
Cr-Commit-Position: refs/heads/master@{#299934}

Powered by Google App Engine
This is Rietveld 408576698