components/autofill/OWNERS - Issue 658973003: Update Autofill component ownership to avoid bugs in OWNERS file parsing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/OWNERS

Issue 658973003: Update Autofill component ownership to avoid bugs in OWNERS file parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 estade@chromium.org	1 estade@chromium.org

2 isherman@chromium.org	2 isherman@chromium.org

3	3

4 # Owners for password autofill/generation only.	4 # Owners for password autofill/generation only.

5 per-file password=gcasto@chromium.org	5 # TODO(gcasto): Change to per-file ownership after http://crbug.com/235756

6 per-file password=vabr@chromium.org	6 # is fixed.

7 per-file autofill_param_traits_macros.h=gcasto@chromium.org	7 gcasto@chromium.org
	blundell 2014/10/20 11:31:07 Is there a need for this? My understanding had bee Is there a need for this? My understanding had been that it the use of a "" was only a problem because it masked //components/autofill/OWNERS. There's no directory under //components/autofill that "password" would match. Garrett Casto* 2014/10/20 17:56:17 Different bug. 235756 is about the fact that per-f Show quoted text On 2014/10/20 11:31:07, blundell wrote: > Is there a need for this? My understanding had been that it the use of a "" was > only a problem because it masked //components/autofill/OWNERS. There's no > directory under //components/autofill that "password*" would match. Different bug. 235756 is about the fact that per-file directives only affect the current directory.
8 per-file autofill_param_traits_macros.h=vabr@chromium.org	8 vabr@chromium.org

OLD	NEW

« no previous file with comments | « components/OWNERS ('k') | no next file » | no next file with comments »