Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 658953003: Remove redundant Mac event structures (Closed)

Created:
6 years, 2 months ago by ccameron
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove redundant Mac event structures The scrollCount field is unused. The unacceleratedScrollingDeltaX/Y field always equal deltaX/Y (by inspection, then by adding an assert and testing), so use those directly. BUG=133097 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -31 lines) Patch
M Source/platform/PlatformWheelEvent.h View 4 chunks +0 lines, -12 lines 0 comments Download
M Source/platform/mac/ScrollElasticityController.mm View 2 chunks +4 lines, -16 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ccameron
Very small simplification, but helps a bit in slogging through.
6 years, 2 months ago (2014-10-16 02:13:08 UTC) #2
ccameron
ping on this guy
6 years, 2 months ago (2014-10-17 00:28:12 UTC) #3
Ken Russell (switch to Gerrit)
LGTM if you've tested this. The math looks right.
6 years, 2 months ago (2014-10-17 00:56:10 UTC) #4
ccameron
Thanks!
6 years, 2 months ago (2014-10-17 01:08:07 UTC) #5
ccameron
Thanks!
6 years, 2 months ago (2014-10-17 01:08:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658953003/1
6 years, 2 months ago (2014-10-17 01:09:17 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 02:21:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183851

Powered by Google App Engine
This is Rietveld 408576698