Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 658943002: Revert of [src/chrome/browser/] Declaring the weak_ptr_factory in proper order in ui and prerender … (Closed)

Created:
6 years, 2 months ago by Peter Kasting
Modified:
6 years, 2 months ago
Reviewers:
cbentzel, ARUNKK, dcheng
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, jkarlin+watch_chromium.org, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [src/chrome/browser/] Declaring the weak_ptr_factory in proper order in ui and prerender (patchset #1 id:1 of https://codereview.chromium.org/612783003/) Reason for revert: Author ignored review comments from multiple reviewers and failed to fix or revert his change after repeated inquiries as to why. Original issue's description: > [src/chrome/browser/] Declaring the weak_ptr_factory in proper order in ui and prerender > > Cleaning up weak_ptr_factory destruction order. > WeakPtrFactory should remain the last member so it'll be destroyed and > invalidate its weak pointers before any other members are destroyed. > > BUG=303818 > > Committed: https://crrev.com/5c10e8618bb1c326b18395224b46c41f60867b30 > Cr-Commit-Position: refs/heads/master@{#299059} TBR=cbentzel@chromium.org,dcheng@chromium.org,kulkarni.a@samsung.com NOTREECHECKS=true NOTRY=true BUG=303818 Committed: https://crrev.com/f7023d2af7b7ad852caca2335c32341192d7e442 Cr-Commit-Position: refs/heads/master@{#299787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/prerender/prerender_local_predictor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658943002/1
6 years, 2 months ago (2014-10-15 23:32:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 23:35:01 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 23:36:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7023d2af7b7ad852caca2335c32341192d7e442
Cr-Commit-Position: refs/heads/master@{#299787}

Powered by Google App Engine
This is Rietveld 408576698