mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h - Issue 658923003: Remove dependency on ui from view_manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

Issue 658923003: Remove dependency on ui from view_manager. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/converters/geometry/geometry_type_converters.h ('K') | « mojo/services/public/cpp/view_manager/lib/view.cc ('k') | mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

index c9a4af452088a5393722e64b9f9801f829762756..3ec5e39e465691a774431ea4c05b630c8578af05 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h

@@ -9,7 +9,6 @@

#include "base/callback.h"

#include "base/memory/scoped_vector.h"

#include "base/memory/weak_ptr.h"

-#include "mojo/converters/geometry/geometry_type_converters.h"

#include "mojo/services/public/cpp/view_manager/types.h"

#include "mojo/services/public/cpp/view_manager/view.h"

#include "mojo/services/public/cpp/view_manager/view_manager.h"

@@ -49,7 +48,7 @@ class ViewManagerClientImpl : public ViewManager,

// Returns true if the specified view was created by this connection.

bool OwnsView(Id id) const;

- void SetBounds(Id view_id, const gfx::Rect& bounds);

+ void SetBounds(Id view_id, const Rect& bounds);

void SetSurfaceId(Id view_id, SurfaceIdPtr surface_id);

void SetFocus(Id view_id);

void SetVisible(Id view_id, bool visible);