Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 658903004: Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
index 02f1e9d2f4ea75380caf4a34409d53e2d1395f61..c97fb4b2500f9d3681c954e7244b6e191a9b43e8 100644
--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
@@ -122,21 +122,15 @@
};
struct SwitchLanguageTestData {
- SwitchLanguageTestData() : success(false), done(false) {}
-
- std::string requested_locale;
- std::string loaded_locale;
- bool success;
+ SwitchLanguageTestData() : result("", "", false), done(false) {}
+
+ locale_util::LanguageSwitchResult result;
bool done;
};
void OnLocaleSwitched(SwitchLanguageTestData* self,
- const std::string& locale,
- const std::string& loaded_locale,
- const bool success) {
- self->requested_locale = locale;
- self->loaded_locale = loaded_locale;
- self->success = success;
+ const locale_util::LanguageSwitchResult& result) {
+ self->result = result;
self->done = true;
}
@@ -144,18 +138,17 @@
const std::string& expected_locale,
const bool expect_success) {
SwitchLanguageTestData data;
- scoped_ptr<locale_util::SwitchLanguageCallback> callback(
- new locale_util::SwitchLanguageCallback(
- base::Bind(&OnLocaleSwitched, base::Unretained(&data))));
- locale_util::SwitchLanguage(locale, true, false, callback.Pass());
+ locale_util::SwitchLanguageCallback callback(
+ base::Bind(&OnLocaleSwitched, base::Unretained(&data)));
+ locale_util::SwitchLanguage(locale, true, false, callback);
// Token writing moves control to BlockingPool and back.
content::RunAllBlockingPoolTasksUntilIdle();
EXPECT_EQ(data.done, true);
- EXPECT_EQ(data.requested_locale, locale);
- EXPECT_EQ(data.loaded_locale, expected_locale);
- EXPECT_EQ(data.success, expect_success);
+ EXPECT_EQ(data.result.requested_locale, locale);
+ EXPECT_EQ(data.result.loaded_locale, expected_locale);
+ EXPECT_EQ(data.result.success, expect_success);
}
void SetUpCrasAndEnableChromeVox(int volume_percent, bool mute_on) {

Powered by Google App Engine
This is Rietveld 408576698