Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 658903004: Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (Closed)

Created:
6 years, 2 months ago by Alexander Alekseev
Modified:
6 years, 2 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (patchset #1 id:1 of https://codereview.chromium.org/653123002/) Reason for revert: The speculative revert didn't help. Original issue's description: > Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchset #17 id:320001 of https://codereview.chromium.org/620563002/) > > Reason for revert: > Speculatively reverting for https://crbug.com/422703 > > Original issue's description: > > ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. > > > > BUG=419030 > > > > Committed: https://crrev.com/d52dffddbf0abe5ca55509a9cdedcd9b0674bb1c > > Cr-Commit-Position: refs/heads/master@{#298860} > > TBR=dzhioev@chromium.org,nkostylev@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=422703 > > Committed: https://crrev.com/f09329c436f4929c1f9ffd59e49aa4aef441338b > Cr-Commit-Position: refs/heads/master@{#299480} TBR=dzhioev@chromium.org,nkostylev@chromium.org NOTREECHECKS=true NOTRY=true BUG=422703 Committed: https://crrev.com/f4af00363b57344b5d024791b751d966a34b0eb8 Cr-Commit-Position: refs/heads/master@{#299883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -229 lines) Patch
M chrome/browser/chromeos/base/locale_util.h View 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/base/locale_util.cc View 6 chunks +27 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +11 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.h View 4 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 8 chunks +174 lines, -48 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 6 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 7 chunks +88 lines, -71 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Alekseev
Created Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs…
6 years, 2 months ago (2014-10-16 13:05:28 UTC) #1
Alexander Alekseev
6 years, 2 months ago (2014-10-17 00:11:17 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/664503003/ by alemate@chromium.org.

The reason for reverting is: Speculatively reverting (second time) for
https://crbug.com/422703 ..

Powered by Google App Engine
This is Rietveld 408576698