Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3213)

Unified Diff: components/metrics/metrics_service.cc

Issue 658903002: Starting a refactor to allow adding metrics on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_provider.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index b6bb8f548f8a2e2ddf5d74eacab5b7f5d0f68d6e..c8315f0c465035e7c377fbdeea1b39eaae2eaec0 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -778,8 +778,8 @@ void MetricsService::CloseCurrentLog() {
current_log->RecordStabilityMetrics(metrics_providers_.get(),
incremental_uptime, uptime);
- RecordCurrentHistograms();
current_log->RecordGeneralMetrics(metrics_providers_.get());
+ RecordCurrentHistograms();
log_manager_.FinishCurrentLog();
}
@@ -1005,9 +1005,8 @@ void MetricsService::PrepareInitialMetricsLog() {
MetricsLog* current_log = log_manager_.current_log();
current_log->RecordStabilityMetrics(metrics_providers_.get(),
base::TimeDelta(), base::TimeDelta());
- RecordCurrentHistograms();
-
current_log->RecordGeneralMetrics(metrics_providers_.get());
+ RecordCurrentHistograms();
log_manager_.FinishCurrentLog();
log_manager_.ResumePausedLog();
« no previous file with comments | « components/metrics/metrics_provider.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698