Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: chrome/browser/metrics/signin_status_metrics_provider.h

Issue 658903002: Starting a refactor to allow adding metrics on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/signin_status_metrics_provider.h
diff --git a/chrome/browser/metrics/signin_status_metrics_provider.h b/chrome/browser/metrics/signin_status_metrics_provider.h
index f4c775ea661ca30f886ad728682bc5b8f817bb88..442b45dff291675d47c47b426d07a08fb019072e 100644
--- a/chrome/browser/metrics/signin_status_metrics_provider.h
+++ b/chrome/browser/metrics/signin_status_metrics_provider.h
@@ -16,11 +16,16 @@
#include "components/signin/core/browser/signin_manager_base.h"
class Browser;
+class ChromeUserMetricsExtension;
namespace base {
class FilePath;
}
+namespace metrics {
+class ChromeUserMetricsExtension;
+}
+
// Collect login status of all opened profiles during one UMA session and record
// the value into a histogram before UMA log is uploaded. It's currently not
// supported on platform chromeos, Android or iOS.
@@ -31,10 +36,9 @@ class SigninStatusMetricsProvider : public metrics::MetricsProvider,
public:
virtual ~SigninStatusMetricsProvider();
- // Record the collected sign-in status into a histogram and re-check current
- // sign-in status to get prepared for the next UMA session. Called by
- // MetricsServiceClient when it is collecting final metrics.
- void RecordSigninStatusHistogram();
+ // metrics::MetricsProvider:
+ void ProvideGeneralMetrics(
+ metrics::ChromeUserMetricsExtension* uma_proto) override;
// Factory method, creates a new instance of this class.
static SigninStatusMetricsProvider* CreateInstance();
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/browser/metrics/signin_status_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698