Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3040)

Unified Diff: chrome/browser/metrics/android_metrics_provider.h

Issue 658903002: Starting a refactor to allow adding metrics on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/feature_utilities.cc ('k') | chrome/browser/metrics/android_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/android_metrics_provider.h
diff --git a/chrome/browser/metrics/android_metrics_provider.h b/chrome/browser/metrics/android_metrics_provider.h
index 31a2dbe004a53b8ab8fa8c8685cd2bdc9e3478c4..8e4a34a6083cc64f870c2fb6d78e6539509786b3 100644
--- a/chrome/browser/metrics/android_metrics_provider.h
+++ b/chrome/browser/metrics/android_metrics_provider.h
@@ -12,6 +12,10 @@
class PrefService;
class PrefRegistrySimple;
+namespace metrics {
+class ChromeUserMetricsExtension;
+}
+
// AndroidMetricsProvider provides Android-specific stability metrics.
class AndroidMetricsProvider : public metrics::MetricsProvider {
public:
@@ -19,11 +23,15 @@ class AndroidMetricsProvider : public metrics::MetricsProvider {
explicit AndroidMetricsProvider(PrefService* local_state);
virtual ~AndroidMetricsProvider();
+ // metrics::MetricsProvider:
+ virtual void ProvideGeneralMetrics(
+ metrics::ChromeUserMetricsExtension* uma_proto) override;
+
// Called when the Activity that the user interacts with is swapped out.
// TODO(asvitkine): Expose a way for Android code to actually invoke this.
void OnForegroundActivityChanged(ActivityTypeIds::Type type);
- // metrics::MetricsDataProvider:
+ // metrics::MetricsProvider:
virtual void ProvideStabilityMetrics(
metrics::SystemProfileProto* system_profile_proto) override;
« no previous file with comments | « chrome/browser/android/feature_utilities.cc ('k') | chrome/browser/metrics/android_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698