components/metrics/metrics_provider.h - Issue 658903002: Starting a refactor to allow adding metrics on upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_provider.h

Issue 658903002: Starting a refactor to allow adding metrics on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switch to using RecordGeneralMetrics Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/metrics_provider.h

diff --git a/components/metrics/metrics_provider.h b/components/metrics/metrics_provider.h

index 9daaaafce245636ebc9107eee945d49940a06354..22afe14d7dc60ac94943a64f70725a8b90d4ddda 100644

--- a/components/metrics/metrics_provider.h

+++ b/components/metrics/metrics_provider.h

@@ -48,7 +48,8 @@ class MetricsProvider {

virtual void ClearSavedStabilityMetrics();

// Provides general metrics that are neither system profile nor stability

- // metrics.

+ // metrics. May also be used to add histograms when final metrics are

+ // collected right before upload.

virtual void ProvideGeneralMetrics(

ChromeUserMetricsExtension* uma_proto);

« chrome/browser/android/feature_utilities.cc ('K') | « chrome/chrome_browser.gypi ('k') | components/metrics/metrics_service.cc » ('j') | no next file with comments »