Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 658853002: Add CRASHPAD_SIMULATE_CRASH() and supporting client code (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add CRASHPAD_SIMULATE_CRASH() and supporting client code. TEST=client_test SimulateCrash.SimulateCrash R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/dd9cf1b367baf7475f15ce16b4364b853ad57904

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+711 lines, -0 lines) Patch
M client/client.gyp View 3 chunks +6 lines, -0 lines 0 comments Download
A client/simulate_crash.h View 1 chunk +24 lines, -0 lines 0 comments Download
A client/simulate_crash_mac.h View 1 chunk +60 lines, -0 lines 2 comments Download
A client/simulate_crash_mac.cc View 1 chunk +244 lines, -0 lines 0 comments Download
A client/simulate_crash_mac_test.cc View 1 chunk +377 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-15 18:25:39 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/658853002/diff/1/client/simulate_crash_mac.h File client/simulate_crash_mac.h (right): https://codereview.chromium.org/658853002/diff/1/client/simulate_crash_mac.h#newcode22 client/simulate_crash_mac.h:22: //! \file Extraneous?
6 years, 2 months ago (2014-10-16 17:38:55 UTC) #3
Mark Mentovai
https://codereview.chromium.org/658853002/diff/1/client/simulate_crash_mac.h File client/simulate_crash_mac.h (right): https://codereview.chromium.org/658853002/diff/1/client/simulate_crash_mac.h#newcode22 client/simulate_crash_mac.h:22: //! \file Robert Sesek wrote: > Extraneous? If you ...
6 years, 2 months ago (2014-10-16 17:51:53 UTC) #4
Mark Mentovai
6 years, 2 months ago (2014-10-17 16:30:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dd9cf1b367baf7475f15ce16b4364b853ad57904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698