mojo_shell crashes on Linux

mojo_shell crashes on Linux

When I refactored the native_viewport code to be cross-platform, I introduced a
re-entrancy bug on Linux where the accelerated widget is available
synchronously. This CL moves the code for opening the viewport out of the
contructor so that we can fully initialize the object before calling any
delegate functions.

R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233880

[Ben Goodger (Google), 2013-11-08 00:02:15]

lgtm

https://codereview.chromium.org/65883002/diff/1/mojo/services/native_viewport...
File mojo/services/native_viewport/native_viewport.h (right):

https://codereview.chromium.org/65883002/diff/1/mojo/services/native_viewport...
mojo/services/native_viewport/native_viewport.h:39: virtual void Open() = 0;
Init() ?

[abarth-chromium, 2013-11-08 00:04:37]

https://codereview.chromium.org/65883002/diff/1/mojo/services/native_viewport...
File mojo/services/native_viewport/native_viewport.h (right):

https://codereview.chromium.org/65883002/diff/1/mojo/services/native_viewport...
mojo/services/native_viewport/native_viewport.h:39: virtual void Open() = 0;
On 2013/11/08 00:02:16, Ben Goodger (Google) wrote:
> Init() ?

Will do.

[commit-bot: I haz the power, 2013-11-08 00:52:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/65883002/90001

[commit-bot: I haz the power, 2013-11-08 01:46:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-08 03:33:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/65883002/340001

[commit-bot: I haz the power, 2013-11-08 12:15:34]

Change committed as 233880