chrome/browser/sync/engine/process_commit_response_command.cc - Issue 6588119: First-time sync: asymptotic running time improvement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/process_commit_response_command.cc

Issue 6588119: First-time sync: asymptotic running time improvement (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/Release

Patch Set: Fix unit_tests Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/engine/process_commit_response_command.cc

diff --git a/chrome/browser/sync/engine/process_commit_response_command.cc b/chrome/browser/sync/engine/process_commit_response_command.cc

index 64eb442864a432d08c47c32085b41fbd5d93c22e..921248baa76c6406ffcb0e378c34818c90aa5b0a 100644

--- a/chrome/browser/sync/engine/process_commit_response_command.cc

+++ b/chrome/browser/sync/engine/process_commit_response_command.cc

@@ -435,8 +435,7 @@ void ProcessCommitResponseCommand::OverrideClientFieldsAfterCommit(

// We just committed successfully, so we assume that the position

// value we got applies to the PARENT_ID we submitted.

- syncable::Id new_prev = SyncerUtil::ComputePrevIdFromServerPosition(

- local_entry->write_transaction(), local_entry,

+ syncable::Id new_prev = local_entry->ComputePrevIdFromServerPosition(

local_entry->Get(PARENT_ID));

if (!local_entry->PutPredecessor(new_prev))

LOG(WARNING) << "PutPredecessor failed after successful commit";