First-time sync: asymptotic running time improvement

chrome/browser/sync/engine/syncer_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Syncer unit tests. Unfortunately a lot of these tests
 // are outdated and need to be reworked and updated.
 
 #include <algorithm>
 #include <limits>
 #include <list>
@@ skipping 3550 matching lines @@
   SyncShareAsDelegate();
   {
     WriteTransaction trans(dir, UNITTEST, __FILE__, __LINE__);
     MutableEntry entry(&trans, CREATE, trans.root_id(), "Copy of base");
     WriteTestDataToEntry(&trans, &entry);
   }
   mock_server_->AddUpdateBookmark(1, 0, "Copy of base", 50, 50);
   SyncRepeatedlyToTriggerConflictResolution(session_.get());
 }
 
-TEST_F(SyncerTest, DISABLED_OneBajillionUpdates) {
+TEST_F(SyncerTest, OneBajillionUpdates) {
   ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
   CHECK(dir.good());
   int one_bajillion = 4000;
 
   syncable::Id parent_id = ids_.MakeServer("Parent");
   mock_server_->AddUpdateDirectory(parent_id, ids_.root(), "foo", 1, 1);
 
   for (int i = 1; i <= one_bajillion; ++i) {
     syncable::Id item_id = ids_.FromNumber(i);
     mock_server_->AddUpdateDirectory(item_id, parent_id, "dude", 1, 1);
@@ skipping 1411 matching lines @@
     EXPECT_TRUE(dir.good());
     ReadTransaction trans(dir, __FILE__, __LINE__);
 
     Id prev_id;
     DCHECK(prev_id.IsRoot());
     PosMap::iterator next = position_map_.begin();
     for (PosMap::iterator i = next++; i != position_map_.end(); ++i) {
       Id id = i->second;
       Entry entry_with_id(&trans, GET_BY_ID, id);
       EXPECT_TRUE(entry_with_id.good());
-      EXPECT_TRUE(entry_with_id.Get(PREV_ID) == prev_id);
-      EXPECT_TRUE(entry_with_id.Get(SERVER_POSITION_IN_PARENT) == i->first);
+      EXPECT_EQ(prev_id, entry_with_id.Get(PREV_ID));
+      EXPECT_EQ(i->first, entry_with_id.Get(SERVER_POSITION_IN_PARENT));
       if (next == position_map_.end()) {
-        EXPECT_TRUE(entry_with_id.Get(NEXT_ID).IsRoot());
+        EXPECT_EQ(Id(), entry_with_id.Get(NEXT_ID));
       } else {
-        EXPECT_TRUE(entry_with_id.Get(NEXT_ID) == next->second);
+        EXPECT_EQ(next->second, entry_with_id.Get(NEXT_ID));
         next++;
       }
       prev_id = id;
     }
   }
 
   void AddRootItemWithPosition(int64 position) {
     string id = string("ServerId") + base::Int64ToString(next_update_id_++);
     string name = "my name is my id -- " + id;
     int revision = next_revision_++;
@@ skipping 174 matching lines @@
   Add(low_id_);
   Add(high_id_);
   SyncShareAsDelegate();
   ExpectLocalOrderIsByServerId();
 }
 
 const SyncerTest::CommitOrderingTest
 SyncerTest::CommitOrderingTest::LAST_COMMIT_ITEM = {-1, TestIdFactory::root()};
 
 }  // namespace browser_sync