Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: client/site_tests/security_BundledCRXs/security_BundledCRXs.py

Issue 6588022: Back-out previous hack of the test, because chrome-os-partner:2414 is resolved. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/autotest.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/site_tests/security_BundledCRXs/security_BundledCRXs.py
diff --git a/client/site_tests/security_BundledCRXs/security_BundledCRXs.py b/client/site_tests/security_BundledCRXs/security_BundledCRXs.py
index 1205cc3bee0200b392a5a2e50cb077e979bd589a..0a8fb961c8c156d821ca81d93f47ef02e85250ed 100644
--- a/client/site_tests/security_BundledCRXs/security_BundledCRXs.py
+++ b/client/site_tests/security_BundledCRXs/security_BundledCRXs.py
@@ -53,14 +53,11 @@ class security_BundledCRXs(test.test):
for crx in diff:
logging.error('New/unexpected bundled crx %s' % crx)
- # Or, things in baseline are missing from the system. We log missing
- # CRX's as warnings instead of test failures because we autotest some
- # builds where extensions aren't bundled. See chrome-os-partner:2414.
- # TODO(jimhebert) make these warnings fatal after 2414 is resolved.
+ # Or, things in baseline are missing from the system:
diff2 = baseline_set.difference(observed_set)
if len(diff2) > 0:
for crx in diff2:
- logging.warning('Missing bundled crx %s' % crx)
+ logging.error('Missing bundled crx %s' % crx)
- if len(diff):
+ if (len(diff) + len(diff2)) > 0:
raise error.TestFail('Baseline mismatch')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698