Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: content/public/common/push_messaging_status.cc

Issue 658783002: Split PushMessagingStatus enum according to use case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/push_messaging_status.h ('k') | content/renderer/push_messaging_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/push_messaging_status.cc
diff --git a/content/public/common/push_messaging_status.cc b/content/public/common/push_messaging_status.cc
index f01cf80ca1fe4ef2f49ea17b6f45f25a5615c02a..7c476408d6ea8b6c6949e01051198f8703973f81 100644
--- a/content/public/common/push_messaging_status.cc
+++ b/content/public/common/push_messaging_status.cc
@@ -8,34 +8,25 @@
namespace content {
-const char* PushMessagingStatusToString(PushMessagingStatus status) {
+const char* PushRegistrationStatusToString(PushRegistrationStatus status) {
switch (status) {
- case PUSH_MESSAGING_STATUS_OK:
- return "Operation has succeeded";
+ case PUSH_REGISTRATION_STATUS_SUCCESS:
+ return "Registration successful";
- case PUSH_MESSAGING_STATUS_REGISTRATION_FAILED_NO_SERVICE_WORKER:
+ case PUSH_REGISTRATION_STATUS_NO_SERVICE_WORKER:
return "Registration failed - no Service Worker";
- case PUSH_MESSAGING_STATUS_REGISTRATION_FAILED_SERVICE_NOT_AVAILABLE:
+ case PUSH_REGISTRATION_STATUS_SERVICE_NOT_AVAILABLE:
return "Registration failed - push service not available";
- case PUSH_MESSAGING_STATUS_REGISTRATION_FAILED_LIMIT_REACHED:
+ case PUSH_REGISTRATION_STATUS_LIMIT_REACHED:
return "Registration failed - registration limit has been reached";
- case PUSH_MESSAGING_STATUS_REGISTRATION_FAILED_PERMISSION_DENIED:
+ case PUSH_REGISTRATION_STATUS_PERMISSION_DENIED:
return "Registration failed - permission denied";
- case PUSH_MESSAGING_STATUS_REGISTRATION_FAILED_SERVICE_ERROR:
+ case PUSH_REGISTRATION_STATUS_SERVICE_ERROR:
return "Registration failed - push service error";
-
- case PUSH_MESSAGING_STATUS_MESSAGE_DELIVERY_FAILED_NO_SERVICE_WORKER:
- return "Message delivery failed - no Service Worker";
-
- case PUSH_MESSAGING_STATUS_MESSAGE_DELIVERY_FAILED_SERVICE_WORKER_ERROR:
- return "Message delivery failed - Service Worker error";
-
- case PUSH_MESSAGING_STATUS_ERROR:
- return "Operation has failed (unspecified reason)";
}
NOTREACHED();
return "";
« no previous file with comments | « content/public/common/push_messaging_status.h ('k') | content/renderer/push_messaging_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698