Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: content/browser/push_messaging_router.cc

Issue 658783002: Split PushMessagingStatus enum according to use case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/push_messaging_router.h ('k') | content/common/push_messaging_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/push_messaging_router.cc
diff --git a/content/browser/push_messaging_router.cc b/content/browser/push_messaging_router.cc
index 05d66f5930e31098d559b126338ca65bb5c46b22..397e160d6aad8a400781de8255310588eee70aad 100644
--- a/content/browser/push_messaging_router.cc
+++ b/content/browser/push_messaging_router.cc
@@ -77,12 +77,10 @@ void PushMessagingRouter::FindServiceWorkerRegistrationCallback(
dispatch_event_callback, data);
} else {
// TODO(mvanouwerkerk): UMA logging.
- BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
- base::Bind(
- deliver_message_callback,
- PUSH_MESSAGING_STATUS_MESSAGE_DELIVERY_FAILED_NO_SERVICE_WORKER));
+ BrowserThread::PostTask(BrowserThread::UI,
+ FROM_HERE,
+ base::Bind(deliver_message_callback,
+ PUSH_DELIVERY_STATUS_NO_SERVICE_WORKER));
}
}
@@ -93,14 +91,14 @@ void PushMessagingRouter::DeliverMessageEnd(
ServiceWorkerStatusCode service_worker_status) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
// TODO(mvanouwerkerk): UMA logging.
- PushMessagingStatus push_messaging_status =
+ PushDeliveryStatus delivery_status =
service_worker_status == SERVICE_WORKER_OK
- ? PUSH_MESSAGING_STATUS_OK
- : PUSH_MESSAGING_STATUS_MESSAGE_DELIVERY_FAILED_SERVICE_WORKER_ERROR;
+ ? PUSH_DELIVERY_STATUS_SUCCESS
+ : PUSH_DELIVERY_STATUS_SERVICE_WORKER_ERROR;
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,
- base::Bind(deliver_message_callback, push_messaging_status));
+ base::Bind(deliver_message_callback, delivery_status));
}
} // namespace content
« no previous file with comments | « content/browser/push_messaging_router.h ('k') | content/common/push_messaging_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698