content/browser/push_messaging_router.h - Issue 658783002: Split PushMessagingStatus enum according to use case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging_router.h

Issue 658783002: Split PushMessagingStatus enum according to use case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Style tweaks Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/push_messaging_router.h

diff --git a/content/browser/push_messaging_router.h b/content/browser/push_messaging_router.h

index f59a2ee552f5ea9e13246cf9b82b99421aa0e8e7..84f30b2b7ac27bdd7e1bd23f400c1a07abd872a9 100644

--- a/content/browser/push_messaging_router.h

+++ b/content/browser/push_messaging_router.h

@@ -19,7 +19,7 @@ class ServiceWorkerRegistration;

class PushMessagingRouter {

public:

- typedef base::Callback<void(PushMessagingStatus /* push_messaging_status */)>

+ typedef base::Callback<void(PushDeliveryStatus /* push_messaging_status */)>

Michael van Ouwerkerk 2014/10/17 12:34:13 Update the comment as well.

johnme 2014/10/17 13:53:38 Removed it, as it wasn't adding anything.

DeliverMessageCallback;

// Delivers a push message with |data| to the Service Worker identified by

« no previous file with comments | « content/browser/push_messaging_message_filter.cc ('k') | content/browser/push_messaging_router.cc » ('j') | no next file with comments »