Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: runtime/vm/deopt_instructions.cc

Issue 658773002: Fix crash with --trace-deoptimization-verbose and tweak formatting. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/deferred_objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/deopt_instructions.cc
===================================================================
--- runtime/vm/deopt_instructions.cc (revision 41128)
+++ runtime/vm/deopt_instructions.cc (working copy)
@@ -267,7 +267,7 @@
if (FLAG_trace_deoptimization_verbose) {
intptr_t* start = dest_frame_;
for (intptr_t i = 0; i < frame_size; i++) {
- OS::PrintErr("*%" Pd ". [%" Px "] %#014" Px " [%s]\n",
+ OS::PrintErr("*%" Pd ". [0x%" Px "] 0x%" Px " [%s]\n",
i,
reinterpret_cast<uword>(&start[i]),
start[i],
@@ -323,7 +323,10 @@
script.GetTokenLocation(token_pos, &line, &column);
String& line_string = String::Handle(script.GetLine(line));
OS::PrintErr(" Function: %s\n", top_function.ToFullyQualifiedCString());
- OS::PrintErr(" Line %" Pd ": '%s'\n", line, line_string.ToCString());
+ char line_buffer[80];
+ OS::SNPrint(line_buffer, sizeof(line_buffer), " Line %" Pd ": '%s'",
+ line, line_string.ToCString());
+ OS::PrintErr("%s\n", line_buffer);
OS::PrintErr(" Deopt args: %" Pd "\n", deopt_arg_count);
}
« no previous file with comments | « runtime/vm/deferred_objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698