Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 658753004: Make wm_flow_init work with gn (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make wm_flow_init work with gn Two sets of changes: . fix gn dependencies . make views_init work in the static library The latter means wm_flow_init and demo_launcher only work with gn (not gyp). BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/b6afb358781de8a6cbdd1b9f45ee00ca4f70581c Cr-Commit-Position: refs/heads/master@{#299807}

Patch Set 1 #

Patch Set 2 : get working #

Patch Set 3 : done #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -174 lines) Patch
M mojo/examples/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/demo_launcher/demo_launcher.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/examples/keyboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/media_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/window_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/wm_flow/BUILD.gn View 4 chunks +11 lines, -2 lines 0 comments Download
M mojo/examples/wm_flow/init/init.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/examples/wm_flow/wm/wm.cc View 1 3 chunks +6 lines, -1 line 0 comments Download
M mojo/mojo.gyp View 1 2 chunks +3 lines, -25 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 1 chunk +6 lines, -9 lines 0 comments Download
M mojo/views/BUILD.gn View 1 2 2 chunks +3 lines, -25 lines 0 comments Download
D mojo/views/mojo_views_export.h View 1 1 chunk +0 lines, -29 lines 0 comments Download
M mojo/views/views_init.cc View 1 1 chunk +37 lines, -1 line 0 comments Download
D mojo/views/views_init_internal.h View 1 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/views/views_init_internal.cc View 1 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
sky
6 years, 2 months ago (2014-10-15 20:05:41 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-10-15 20:07:29 UTC) #2
sky
I modified this (and changed the subject) so that it all works with gn. Take ...
6 years, 2 months ago (2014-10-15 20:42:28 UTC) #3
Ben Goodger (Google)
slgtm
6 years, 2 months ago (2014-10-15 22:14:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658753004/40001
6 years, 2 months ago (2014-10-15 22:22:04 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-16 01:20:36 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 01:21:49 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b6afb358781de8a6cbdd1b9f45ee00ca4f70581c
Cr-Commit-Position: refs/heads/master@{#299807}

Powered by Google App Engine
This is Rietveld 408576698