Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 658753003: Exiting Chrome from the wrench menu should close the User Manager. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, Mike Lerman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Exiting Chrome from the wrench menu should close the User Manager. The User Manager is not a browser window, so the only way it can stay open while all browser windows are closed is by having an AutoKeepAlive. This means, however that if the User Manager is showing, "Exit Chrome" from the wrench menu will have no affect. The solution is to close the User Manager first, then exit as before. BUG=423099 TEST=Start Chrome with --enable-new-avatar-menu. Select "Switch Person" from the avatar menu. Select "Exit" from the hot dog menu. Chrome should exit. Committed: https://crrev.com/d710bc8339e2c458f9fd708f0b547d407490a59a Cr-Commit-Position: refs/heads/master@{#299754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/lifetime/application_lifetime.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
noms (inactive)
This fixes a bug where trying to exit Chrome from the hot dog menu while ...
6 years, 2 months ago (2014-10-15 15:35:45 UTC) #2
Lei Zhang
+mlerman who is probably more familiar with this code.
6 years, 2 months ago (2014-10-15 19:07:16 UTC) #4
noms (inactive)
On 2014/10/15 19:07:16, Lei Zhang wrote: > +mlerman who is probably more familiar with this ...
6 years, 2 months ago (2014-10-15 19:08:24 UTC) #5
Lei Zhang
Ok, this makes sense to me, so lgtm.
6 years, 2 months ago (2014-10-15 19:16:29 UTC) #6
noms (inactive)
On 2014/10/15 19:16:29, Lei Zhang wrote: > Ok, this makes sense to me, so lgtm. ...
6 years, 2 months ago (2014-10-15 20:13:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658753003/1
6 years, 2 months ago (2014-10-15 20:14:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 20:27:45 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 20:29:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d710bc8339e2c458f9fd708f0b547d407490a59a
Cr-Commit-Position: refs/heads/master@{#299754}

Powered by Google App Engine
This is Rietveld 408576698