Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 658743004: Move the Editor and Eclipse plugins over to using stagehand for the new project templates. (Closed)

Created:
6 years, 2 months ago by devoncarew
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, jwren, pquitslund
Visibility:
Public.

Description

Move the Editor and Eclipse plugins over to using stagehand for the new project templates. R=danrubel@google.com, pquitslund@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41339

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -53 lines) Patch
M editor/docs/english.dictionary View 1 1 chunk +3 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.eclipse.ui/src/com/google/dart/eclipse/wizards/DartProjectWizard.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.eclipse.ui/src/com/google/dart/eclipse/wizards/DartProjectWizardPage.java View 1 2 chunks +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.eclipse.ui/src/com/google/dart/eclipse/wizards/SamplesComposite.java View 1 5 chunks +57 lines, -20 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/AbstractSample.java View 1 5 chunks +57 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/ChromePackagedAppSample.java View 1 1 chunk +1 line, -1 line 0 comments Download
A editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/Stagehand.java View 1 1 chunk +176 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/StagehandException.java View 1 chunk +25 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/StagehandSample.java View 1 1 chunk +75 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/CreateApplicationWizard.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/projects/NewApplicationCreationPage.java View 1 6 chunks +42 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
devoncarew
Move the Editor and the Eclipse plugins over to using Stagehand for the new project ...
6 years, 2 months ago (2014-10-24 20:50:20 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-24 21:00:05 UTC) #3
pquitslund
LGTM!
6 years, 2 months ago (2014-10-24 22:34:31 UTC) #5
danrubel
Sweet! LGTM
6 years, 1 month ago (2014-10-27 01:35:17 UTC) #6
devoncarew
6 years, 1 month ago (2014-10-27 21:00:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r41339 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698