Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: Source/modules/serviceworkers/Cache.cpp

Issue 658743003: Service Workers: Cache.put() should resolve to undefined (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/serviceworker/cache-put-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/Cache.cpp
diff --git a/Source/modules/serviceworkers/Cache.cpp b/Source/modules/serviceworkers/Cache.cpp
index a1c4d8694c7cafba6ce2adaba371cf62efbffc6b..0ab8ff50d624577fcfba708cba32d99fd52baa78 100644
--- a/Source/modules/serviceworkers/Cache.cpp
+++ b/Source/modules/serviceworkers/Cache.cpp
@@ -78,16 +78,16 @@ protected:
};
// FIXME: Consider using CallbackPromiseAdapter.
-class CacheWithOneResponseCallbacks : public CacheWithResponsesCallbacks {
- WTF_MAKE_NONCOPYABLE(CacheWithOneResponseCallbacks);
+class CacheAddOrPutCallbacks : public CacheWithResponsesCallbacks {
+ WTF_MAKE_NONCOPYABLE(CacheAddOrPutCallbacks);
public:
- CacheWithOneResponseCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ CacheAddOrPutCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
: CacheWithResponsesCallbacks(resolver) { }
virtual void onSuccess(WebVector<WebServiceWorkerResponse>* webResponses) override
{
- ASSERT(webResponses->size() == 1);
- m_resolver->resolve(Response::create(m_resolver->scriptState()->executionContext(), (*webResponses)[0]));
+ // FIXME: Since response is ignored, consider simplifying public API.
+ m_resolver->resolve();
m_resolver.clear();
}
};
@@ -101,6 +101,7 @@ public:
virtual void onSuccess(WebVector<WebServiceWorkerResponse>* webResponses) override
{
+ // FIXME: Since response is ignored, consider simplifying public API.
m_resolver->resolve(true);
m_resolver.clear();
}
@@ -384,7 +385,7 @@ ScriptPromise Cache::putImpl(ScriptState* scriptState, Request* request, Respons
RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
- m_webCache->dispatchBatch(new CacheWithOneResponseCallbacks(resolver), batchOperations);
+ m_webCache->dispatchBatch(new CacheAddOrPutCallbacks(resolver), batchOperations);
return promise;
}
« no previous file with comments | « LayoutTests/http/tests/serviceworker/cache-put-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698