Issue 658743003: Service Workers: Cache.put() should resolve to undefined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 658743003: Service Workers: Cache.put() should resolve to undefined (Closed)

Created:
6 years, 2 months ago by jsbell

Modified:
6 years, 2 months ago

Reviewers:
jkarlin

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, asanka

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Service Workers: Cache.put() should resolve to undefined Spec was updated with the determination that add(), addAll() and put() should resolve to `undefined`, not the response(s). Only put() is currently implemented; update the resolution type. BUG=425469 R=jkarlin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184307

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	LayoutTests/http/tests/serviceworker/cache-put-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/modules/serviceworkers/Cache.cpp	View		3 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jkarlin

lgtm I'm adding a note to the bug that more needs to be done to ...

6 years, 2 months ago (2014-10-23 21:20:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658743003/1

6 years, 2 months ago (2014-10-23 22:54:42 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-23 23:00:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184307

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages