Issue 658743002: Refine typing of addition, subtraction, multiplication, and division.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 658743002: Refine typing of addition, subtraction, multiplication, and division. (Closed)

Created:
6 years, 2 months ago by neis

Modified:
6 years, 1 month ago

Reviewers:
Jarin, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Refine typing of addition, subtraction, multiplication, and division. Also speed up fixpoint iteration in the presence of range types. R=jarin@chromium.org, rossberg@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Rangify (unions of) constants to get monotonicity. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -35 lines)			Patch
M	src/compiler/typer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/typer.cc	View	1	18 chunks	+186 lines, -32 lines	0 comments	Download
M	src/types.h	View		4 chunks	+21 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-typer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-types.cc	View	1	6 chunks	+34 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

neis

6 years, 2 months ago (2014-10-20 18:20:54 UTC) #3

Just for the record, several changes should be made to weakening.

- It must be monotone.
- It should only return range types.
- These range types should include some that don't have a corresponding bitset
type.  E.g. the range of "safe" integers.
- If only the minimum has changed, then probably only the minimum should be
weakened.  Similarly for the maximum.
- After weakening, widening needs to remember the node.  That's because future
results will generally have to be weakened as well in order to ensure
termination (relying on monotonicty of weakening).

Expand Messages | Collapse Messages