chrome/common/extensions/docs/server2/cache_chain_object_store.py - Issue 658733004: Docserver: Make ObjectStore set calls return Futures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/cache_chain_object_store.py

Issue 658733004: Docserver: Make ObjectStore set calls return Futures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/appengine_wrappers.py ('k') | chrome/common/extensions/docs/server2/memcache_object_store.py » ('j') | chrome/common/extensions/docs/server2/memcache_object_store.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/cache_chain_object_store.py

diff --git a/chrome/common/extensions/docs/server2/cache_chain_object_store.py b/chrome/common/extensions/docs/server2/cache_chain_object_store.py

index 6741d5f503c5b3acaf5912d044a1387ab7556f8e..62a91b5b05b64826b7071a4ca089cfdd9160a466 100644

--- a/chrome/common/extensions/docs/server2/cache_chain_object_store.py

+++ b/chrome/common/extensions/docs/server2/cache_chain_object_store.py

@@ -2,7 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-from future import Future

+from future import All, Future

from object_store import ObjectStore

@@ -29,8 +29,8 @@ class CacheChainObjectStore(ObjectStore):

def SetMulti(self, mapping):

self._cache.update(mapping)

- for object_store in self._object_stores:

- object_store.SetMulti(mapping)

+ return All(object_store.SetMulti(mapping)

Ken Rockot(use gerrit already) 2014/10/23 20:16:18 Actually we don't want to force callers to Get the

not at google - send to devlin 2014/10/23 20:18:08 ah good point. You might want to add a comment for

+ for object_store in self._object_stores)

def GetMulti(self, keys):

missing_keys = list(keys)