Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 658723006: DevTools: fix changing of cursor while dragging (Closed)

Created:
6 years, 2 months ago by caseq
Modified:
6 years, 2 months ago
Reviewers:
apavlov, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: fix changing of cursor while dragging We used to change cursor upon drag on body only, but this now doesn't have effect since we explicitly set cursor: default in .component-root. So set the cursor explicitly both on the event target and body (the latter is needed so that cursor change also has effect on the glass pane). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184356

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M Source/devtools/front_end/ui/UIUtils.js View 2 chunks +14 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
caseq
6 years, 2 months ago (2014-10-20 15:38:30 UTC) #2
vsevik
lgtm https://codereview.chromium.org/658723006/diff/1/Source/devtools/front_end/ui/UIUtils.js File Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/658723006/diff/1/Source/devtools/front_end/ui/UIUtils.js#newcode90 Source/devtools/front_end/ui/UIUtils.js:90: targetElement.style.cursor = oldCursor; Shouldn't this be behind if ...
6 years, 2 months ago (2014-10-23 08:03:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658723006/1
6 years, 2 months ago (2014-10-24 12:04:50 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 13:05:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184356

Powered by Google App Engine
This is Rietveld 408576698