public/platform/WebPushClient.h - Issue 658723003: Blink implementation of PushManager#hasPermission()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebPushClient.h

Issue 658723003: Blink implementation of PushManager#hasPermission() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/push_messaging/PushPermissionCallback.cpp ('K') | « Source/modules/push_messaging/PushPermissionCallback.cpp ('k') | public/platform/WebPushPermissionCallback.h » ('j') | public/platform/WebPushPermissionCallback.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/WebPushClient.h

diff --git a/public/platform/WebPushClient.h b/public/platform/WebPushClient.h

index 3804bd2deff91e690484a0e0375de9ac15cb15dd..c107834e831ccc544af9e89a033d6a21e3e2d85e 100644

--- a/public/platform/WebPushClient.h

+++ b/public/platform/WebPushClient.h

@@ -7,7 +7,7 @@

#include "public/platform/WebCallbacks.h"

#include "public/platform/WebPushError.h"

-#include "public/platform/WebString.h"

+#include "public/platform/WebPushPermissionCallback.h"

Peter Beverloo 2014/10/20 12:23:49 You should forward declare this instead.

Miguel Garcia 2014/10/22 12:58:44 Done.

namespace blink {

@@ -23,6 +23,10 @@ public:

// Ownership of the WebPushRegistrationCallbacks is transferred to the

// client. Ownership of the WebServiceWorkerProvider is not transferred.

virtual void registerPushMessaging(const WebString& senderId, WebPushRegistrationCallbacks*, WebServiceWorkerProvider*) { }

+ // Ownership of the WebPushPermissionCallback is transferred to the

+ // client. Ownership of the WebServiceWorkerProvider is not transferred.

+ virtual void permissionStatus(WebPushPermissionCallback*, WebServiceWorkerProvider*) { }

};

} // namespace blink