Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: Source/modules/push_messaging/PushManager.cpp

Issue 658723003: Blink implementation of PushManager#hasPermission() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Upgrade the push-messaging-api-surface-actual layout test to include hasPermission Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushManager.cpp
diff --git a/Source/modules/push_messaging/PushManager.cpp b/Source/modules/push_messaging/PushManager.cpp
index 1468d880d342ac3587df10d56c8d8d913a1c3329..e55b22d5e9a80a77564cf1eeb90c5a0a253541ef 100644
--- a/Source/modules/push_messaging/PushManager.cpp
+++ b/Source/modules/push_messaging/PushManager.cpp
@@ -16,6 +16,7 @@
#include "core/frame/LocalDOMWindow.h"
#include "modules/push_messaging/PushController.h"
#include "modules/push_messaging/PushError.h"
+#include "modules/push_messaging/PushPermissionCallback.h"
#include "modules/push_messaging/PushRegistration.h"
#include "modules/serviceworkers/NavigatorServiceWorker.h"
#include "modules/serviceworkers/ServiceWorkerContainer.h"
@@ -28,6 +29,8 @@ PushManager::PushManager()
{
}
+// FIXME: This call should be available from workers which will not have a Document object available.
+// See crbug.com/389194
ScriptPromise PushManager::registerPushMessaging(ScriptState* scriptState, const String& senderId)
{
ASSERT(scriptState->executionContext()->isDocument());
@@ -49,4 +52,28 @@ ScriptPromise PushManager::registerPushMessaging(ScriptState* scriptState, const
return promise;
}
+// FIXME: This call should be available from workers which will not have a Document object available.
+// See crbug.com/389194
+ScriptPromise PushManager::hasPermission(ScriptState* scriptState)
+{
+ ASSERT(scriptState->executionContext()->isDocument());
+
+ Document* document = toDocument(scriptState->executionContext());
+ if (!document->domWindow() || !document->page())
+ return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "Document is detached from window."));
+ blink::WebPushClient* client = PushController::clientFrom(document->page());
+ ASSERT(client);
+
+ // The currently implemented specification does not require a Service Worker to be present for the
+ // hasPermission() call to work, but it will become a requirement soon.
+ WebServiceWorkerProvider* serviceWorkerProvider = NavigatorServiceWorker::serviceWorker(document->domWindow()->navigator())->provider();
+ if (!serviceWorkerProvider)
+ return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "No Service Worker installed for this document."));
+
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+
+ client->getPermissionStatus(new PushPermissionCallback(resolver), serviceWorkerProvider);
+ return resolver->promise();
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698