LayoutTests/push_messaging/push-messaging-api-surface.html - Issue 658723003: Blink implementation of PushManager#hasPermission()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/push_messaging/push-messaging-api-surface.html

Issue 658723003: Blink implementation of PushManager#hasPermission() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Upgrade the push-messaging-api-surface-actual layout test to include hasPermission Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/push_messaging/push-messaging-api-surface-expected.txt » ('j') | Source/modules/push_messaging/PushPermissionCallback.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/push_messaging/push-messaging-api-surface.html

diff --git a/LayoutTests/push_messaging/push-messaging-api-surface.html b/LayoutTests/push_messaging/push-messaging-api-surface.html

index 8c495b05def5524716e5de5a8646c42832685b2d..b97e6bedfb3c539188cac61827ca7a9620433dac 100644

--- a/LayoutTests/push_messaging/push-messaging-api-surface.html

+++ b/LayoutTests/push_messaging/push-messaging-api-surface.html

@@ -10,6 +10,9 @@ description('Tests the Push API surface.');

shouldBeTrue('!!navigator.push');

shouldBeTrue('!!navigator.push.register');

shouldBe('navigator.push.register("senderId").constructor', 'Promise');

+shouldBeTrue('!!navigator.push.hasPermission');

+shouldBe('navigator.push.hasPermission().constructor', 'Promise');

</script>

</body>

</html>

« no previous file with comments | « no previous file | LayoutTests/push_messaging/push-messaging-api-surface-expected.txt » ('j') | Source/modules/push_messaging/PushPermissionCallback.h » ('J')