Blink implementation of PushManager#hasPermission()

Source/modules/push_messaging/PushPermissionCallback.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PushPermissionCallback_h
+#define PushPermissionCallback_h
+
+#include "public/platform/WebPushPermissionCallback.h"
+#include "wtf/Noncopyable.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefPtr.h"
+
+namespace WTF {
+class String;

[Michael van Ouwerkerk, 2014/10/20 11:25:42]

Do you need to declare this? Noone else seems to.

[Peter Beverloo, 2014/10/20 12:23:49]

I'd argue that IWYU is a good thing. Neither of the previously included files
sounds like it's in any way related to a WTF::String.

[Miguel Garcia, 2014/10/22 12:58:44]

Agreed, I think it is a bad idea to not include things just because they are
probably included somewhere else.

+}
+
+namespace blink {
+
+class ScriptPromiseResolver;
+
+// Will resolve the underlying promise depending on the permission
+// passed to the callback.

[Peter Beverloo, 2014/10/20 12:23:49]

nit: no need for the linebreak.

[Miguel Garcia, 2014/10/22 12:58:44]

Sigh

+class PushPermissionCallback final : public WebPushPermissionCallback {
+    WTF_MAKE_NONCOPYABLE(PushPermissionCallback);
+public:
+    PushPermissionCallback(PassRefPtr<ScriptPromiseResolver>);

[Michael van Ouwerkerk, 2014/10/20 11:25:42]

explicit

[Miguel Garcia, 2014/10/22 12:58:44]

Done.

+    virtual ~PushPermissionCallback();
+
+    virtual void onSuccess(PushPermissionStatus) override;
+
+    // Called if for some reason the status of the push permission cannot be checked.
+    virtual void onError() override;
+
+private:
+    static const WTF::String& permissionString(PushPermissionStatus);

[Michael van Ouwerkerk, 2014/10/20 11:25:42]

No need for WTF:: because we're using :-)
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Miguel Garcia, 2014/10/22 12:58:44]

Really? Is this in some guideline I'v missed? Otherwise I prefer to leave it.
When I read this file I want to know what String class exactly is the one I am
using without having to WTFString.h to see if there is a using statement there
or not. Especially since I am not #including that file here, just forward
declaring it.

[Michael van Ouwerkerk, 2014/10/22 13:20:01]

I linked to the using statement above, that's one guideline. Precedent is
another. This code lives in /modules/ ... WTF::String is the default type there
and the namespace is always omitted. It seems to be the pattern in Blink
generally, excepting some string conversion routines.

+    RefPtr<ScriptPromiseResolver> m_resolver;
+};
+
+} // namespace blink
+
+#endif // PushPermissionCallback_h