Blink implementation of PushManager#hasPermission()

public/platform/WebPushPermissionCallback.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WebPushPermissionCallback_h
+#define WebPushPermissionCallback_h
+
+// Interface to be used by the embedder in order
+// to inform Blink when once the permission status for push has been checked.
+namespace blink {
+
+class WebPushPermissionCallback {
+    public:
+
+        enum PushPermissionStatus {
+            PushPermissionGranted = 0,

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

nit: do you need to set to 0? I'm not sure if there is a Blink convention
regarding that but I would tend to say that not setting the initial value is a
better practice.

[Miguel Garcia, 2014/10/20 09:58:10]

I've seen this in many other enums (like notifications)

+            PushPermissionDenied,
+            PushPermissionDefault,
+
+            // Used for IPC message range checks.
+            PushPermissionTypeLast = PushPermissionDefault

[mlamouri (slow - plz ping), 2014/10/17 09:22:02]

I think it would be fine to simply use PushPermissionDefault in the IPC checks.
It is not mandatory to create a TypeLast entry for the IPC checks, mostly
because that value has to be inclusive and having a TypeLast entry that is equal
to the previous entry is odd.

[Miguel Garcia, 2014/10/20 09:58:10]

I'll ask the security reviewer once I send it out. For now I rather leave it.

+        };
+
+        virtual ~WebPushPermissionCallback()
+        {
+        }

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

nit: I think the coding style would require something like:
virtual ~WebPushPermissionCallback() { }

[Miguel Garcia, 2014/10/20 09:58:10]

Done.

+
+        virtual void onSuccess(PushPermissionStatus) = 0;
+        virtual void onError() = 0;
+};
+
+} // namespace blink
+#endif // WebPushPermissionCallback_h