Blink implementation of PushManager#hasPermission()

Source/modules/push_messaging/PushPermissionCallback.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PushPermissionCallback_h
+#define PushPermissionCallback_h
+
+#include "public/platform/WebPushPermissionCallback.h"
+#include "wtf/Noncopyable.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefPtr.h"
+
+namespace WTF {
+class String;
+}
+
+namespace blink {
+
+class ScriptPromiseResolver;
+
+// Will resolve the underlying promise depending on the permission
+// passed to the callback.
+class PushPermissionCallback final : public WebPushPermissionCallback {
+    WTF_MAKE_NONCOPYABLE(PushPermissionCallback);
+
+    public:

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

coding style:
- there is a useless empty line before "public:"
- "public:" should not be indented.

[Miguel Garcia, 2014/10/20 09:58:10]

Done.

+        PushPermissionCallback(PassRefPtr<ScriptPromiseResolver>);
+        virtual ~PushPermissionCallback();
+
+        // Called if the embedder is able to check the status of the push permission.

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

nit: I would put those comments in WebPushPermissionCallback and just point that
those methods are implementing the interface.

[Miguel Garcia, 2014/10/20 09:58:10]

Done.

+        virtual void onSuccess(PushPermissionStatus) override;
+
+        // Called if for some reason the status of the push permission cannot be checked.
+        virtual void onError() override;
+
+    private:
+        static const WTF::String& permissionString(PushPermissionStatus);

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

Could you move that in an anonymous namespace in the cpp file?

+        RefPtr<ScriptPromiseResolver> m_resolver;
+};
+
+} // namespace blink
+
+#endif // PushPermissionCallback_h