Blink implementation of PushManager#hasPermission()

Source/modules/push_messaging/PushPermissionCallback.cpp

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

nit: no new line between "config.h" and the header inclusion.

[Miguel Garcia, 2014/10/20 09:58:10]

Done.

+#include "modules/push_messaging/PushPermissionCallback.h"
+
+#include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "core/dom/DOMException.h"
+#include "core/dom/ExceptionCode.h"
+#include "wtf/text/WTFString.h"
+
+
+namespace blink {
+
+PushPermissionCallback::PushPermissionCallback(PassRefPtr<ScriptPromiseResolver> script_resolver) :
+    m_resolver(script_resolver)
+{
+}
+
+PushPermissionCallback::~PushPermissionCallback()
+{
+}
+
+
+/* static */ const String& PushPermissionCallback::permissionString(PushPermissionStatus type)
+{
+    DEFINE_STATIC_LOCAL(const String, grantedPermission, ("granted"));
+    DEFINE_STATIC_LOCAL(const String, deniedPermission, ("denied"));
+    DEFINE_STATIC_LOCAL(const String, defaultPermission, ("default"));

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

I think "default" is an unfortunate name :(

[Miguel Garcia, 2014/10/20 09:58:10]

not much I can do here talk to Michael, he is a spec editor :) 

On a more serious note, we discussed using "ask" or "prompt" but it is not clear
that the default behaviour is always to prompt. The default could be 3 push
messages for free for example.

+
+    switch (type) {
+    case PushPermissionStatus::PushPermissionGranted:
+        return grantedPermission;
+    case PushPermissionStatus::PushPermissionDenied:
+        return deniedPermission;
+    case PushPermissionStatus::PushPermissionDefault:
+        return defaultPermission;
+    }
+
+    ASSERT_NOT_REACHED();
+    return deniedPermission;
+}
+
+void PushPermissionCallback::onSuccess(PushPermissionStatus type)
+{
+    m_resolver->resolve(permissionString(type));

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

Actually, do you really need permissionString() to be a different method? It
seems that you only need it here.

[Miguel Garcia, 2014/10/20 09:58:10]

It seems nicer but this is just a matter of tase (plus it could be tested
separately) I can inline it if you insist.

+}
+
+void PushPermissionCallback::onError()
+{
+    m_resolver->reject(DOMException::create(SecurityError, "Could not check permission"));

[mlamouri (slow - plz ping), 2014/10/17 09:22:01]

I would not use SecurityError because this isn't a real security error. What
about "UnknownError"? Feel free to have a look at the list of error names and
pick one that sounds appropriate:
http://heycam.github.io/webidl/#dfn-error-names-table

[Miguel Garcia, 2014/10/20 09:58:10]

OperationError ?

+}
+
+} // namespace blink