Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 658683003: Add --enable-image-color-profiles command line switch (Closed)

Created:
6 years, 2 months ago by Noel Gordon
Modified:
6 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Mike West, jochen (gone - plz use gerrit), Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add --enable-image-color-profiles command line switch Chromium-side plumbing for image color profiles web runtime enable feature: https://codereview.chromium.org/646033003 BUG=423670, 369787 Committed: https://crrev.com/f552c5175a7e1f75cc39be1124864f193abfff17 Cr-Commit-Position: refs/heads/master@{#302893}

Patch Set 1 #

Patch Set 2 : ~alpha-order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
Noel Gordon
6 years, 2 months ago (2014-10-16 08:22:13 UTC) #2
Mike West
IPC LGTM. The rest looks fine as well, but you'll need a content/ OWNER to ...
6 years, 2 months ago (2014-10-16 12:11:32 UTC) #7
Noel Gordon
Thanks, +nasko, cc jochen.
6 years, 2 months ago (2014-10-16 12:24:10 UTC) #8
Noel Gordon
Going OOO till Nov 4. Mike, if you could please shepherd this through review and ...
6 years, 2 months ago (2014-10-18 03:36:01 UTC) #10
nasko
LGTM
6 years, 2 months ago (2014-10-20 17:03:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658683003/20001
6 years, 1 month ago (2014-11-05 04:35:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22210)
6 years, 1 month ago (2014-11-05 04:38:37 UTC) #15
Noel Gordon
+Alexander fpr cros OWNERS
6 years, 1 month ago (2014-11-05 04:54:57 UTC) #17
Alexander Alekseev
lgtm
6 years, 1 month ago (2014-11-05 14:16:25 UTC) #18
Alexander Alekseev
Note: This switch could probably be used on ChromeOS (as you needed to modify chrome/browser/chromeos/ ...
6 years, 1 month ago (2014-11-05 14:22:19 UTC) #19
Noel Gordon
Thanks Alexander. The switch is per-system, and no plan to make it per-user at this ...
6 years, 1 month ago (2014-11-05 22:09:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658683003/20001
6 years, 1 month ago (2014-11-05 22:12:03 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 22:53:36 UTC) #23
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 22:54:06 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f552c5175a7e1f75cc39be1124864f193abfff17
Cr-Commit-Position: refs/heads/master@{#302893}

Powered by Google App Engine
This is Rietveld 408576698