Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 658633003: Remove deprecated lexer-shell. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
ulan, marja
CC:
v8-dev, Igor Sheludko, Jarin, dcarney
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -344 lines) Patch
M build/all.gyp View 1 chunk +1 line, -2 lines 0 comments Download
D tools/lexer-shell.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D tools/lexer-shell.gyp View 1 chunk +0 lines, -82 lines 0 comments Download
A + tools/parser-shell.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
M tools/shell-utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-23 11:05:38 UTC) #1
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-23 11:06:06 UTC) #2
marja
lgtm ulan, are some bots running lexer-shell still?
6 years, 2 months ago (2014-10-23 11:06:29 UTC) #3
ulan
lgtm > ulan, are some bots running lexer-shell still? Redirecting the question to Michael.
6 years, 2 months ago (2014-10-23 11:13:03 UTC) #4
Michael Achenbach
nope - we removed this bot some time ago...
6 years, 2 months ago (2014-10-23 11:20:42 UTC) #5
Benedikt Meurer
6 years, 2 months ago (2014-10-23 11:42:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24838 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698