Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 658633002: Update EME playback-multiple-sessions test to avoid flakiness (Closed)

Created:
6 years, 2 months ago by jrummell
Modified:
6 years, 2 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Update EME playback-multiple-sessions test to avoid flakiness Update the test to not call generateRequest() for either stream until both "onencrypted" events are received. This is to avoid the occasional race condition where the first "message" event arrives before the second "onencrypted" event, and thus messes up the expected-output log comparison. BUG=407993 TEST=modified test still pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183842

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html View 1 2 chunks +41 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
jrummell
PTAL.
6 years, 2 months ago (2014-10-14 21:44:43 UTC) #2
sandersd (OOO until July 31)
lgtm
6 years, 2 months ago (2014-10-14 22:31:05 UTC) #3
ddorwin
LGTM % comments https://codereview.chromium.org/658633002/diff/1/LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html File LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html (right): https://codereview.chromium.org/658633002/diff/1/LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html#newcode60 LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html:60: // "message" event from occurring before ...
6 years, 2 months ago (2014-10-16 16:14:32 UTC) #4
jrummell
Thanks for the reviews. https://codereview.chromium.org/658633002/diff/1/LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html File LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html (right): https://codereview.chromium.org/658633002/diff/1/LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html#newcode60 LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html:60: // "message" event from occurring ...
6 years, 2 months ago (2014-10-16 17:42:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658633002/20001
6 years, 2 months ago (2014-10-16 17:44:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64312)
6 years, 2 months ago (2014-10-16 18:47:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658633002/20001
6 years, 2 months ago (2014-10-16 18:56:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64312)
6 years, 2 months ago (2014-10-16 19:03:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658633002/20001
6 years, 2 months ago (2014-10-16 23:19:14 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 23:20:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183842

Powered by Google App Engine
This is Rietveld 408576698