Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 658593002: Roll WebRTC 7390:7447. (Closed)

Created:
6 years, 2 months ago by hellner1
Modified:
6 years, 2 months ago
Reviewers:
mikhal1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll WebRTC 7390:7447. NOTRY=true BUG=N/A Committed: https://crrev.com/45b1f8d30351657be732e73cf1975f4a8a06fae6 Cr-Commit-Position: refs/heads/master@{#299695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hellner1
PTAL
6 years, 2 months ago (2014-10-15 16:32:29 UTC) #2
mikhal1
lgtm
6 years, 2 months ago (2014-10-15 16:38:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658593002/1
6 years, 2 months ago (2014-10-15 16:46:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 16:47:19 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/45b1f8d30351657be732e73cf1975f4a8a06fae6 Cr-Commit-Position: refs/heads/master@{#299695}
6 years, 2 months ago (2014-10-15 16:48:03 UTC) #9
jochen (gone - plz use gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/641203005/ by jochen@chromium.org. ...
6 years, 2 months ago (2014-10-17 11:52:25 UTC) #10
hellner1
6 years, 2 months ago (2014-10-17 14:34:32 UTC) #11
Message was sent while issue was closed.
On 2014/10/17 11:52:25, jochen wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/641203005/ by mailto:jochen@chromium.org.
> 
> The reason for reverting is: regresses BSS size (doubles it).
> 
> also, no try for a roll??.

I sent try jobs first. There are some timing requirements that need to be
considered when rolling WebRTC. I can give you the details if you really want to
know :)

Here is some precedence if you want a quick sanity check:
https://codereview.chromium.org/635303002

Powered by Google App Engine
This is Rietveld 408576698