Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 658583006: [ServiceWorkerCache] Make ServiceWorkerCache::Put guarantee callback like the header says (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 1 month ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorkerCache] Make ServiceWorkerCache::Put guarantee callback like the header says The Put() function performs an async init() with a weakptr callback. If the weakptr is null then the callback won't be called, breaking the contract that Put()'s callback will always be called. This CL fixes that by making the PutImpl callback a static member (so that it can access Cache::backend_). The other Put callbacks and its necessary classes came along for the ride. Upstream of: https://codereview.chromium.org/649203005 BUG=426964 Committed: https://crrev.com/84de81c732b9f4289b1af338e9cd2844fd0e7429 Cr-Commit-Position: refs/heads/master@{#301355}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -360 lines) Patch
M content/browser/service_worker/service_worker_cache.h View 1 3 chunks +12 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 1 6 chunks +347 lines, -353 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jkarlin
michaeln@chromium.org: Please review changes in all horo@chromium.org: Please review changes in all The real motivation ...
6 years, 2 months ago (2014-10-24 19:21:11 UTC) #2
michaeln
lgtm
6 years, 2 months ago (2014-10-24 22:06:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658583006/1
6 years, 2 months ago (2014-10-24 22:51:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/73459) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/78381) android_aosp ...
6 years, 2 months ago (2014-10-24 22:59:04 UTC) #7
jkarlin
On 2014/10/24 22:59:04, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-24 23:26:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658583006/20001
6 years, 1 month ago (2014-10-27 12:58:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 13:43:06 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 13:44:00 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84de81c732b9f4289b1af338e9cd2844fd0e7429
Cr-Commit-Position: refs/heads/master@{#301355}

Powered by Google App Engine
This is Rietveld 408576698