Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 658563010: Update virtual/final usage in url/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update virtual/final usage in url/. BUG=417463 R=brettw@chromium.org Committed: https://crrev.com/b424ebc2b0ea7c7cfc448c07d0375a49bb797d4d Cr-Commit-Position: refs/heads/master@{#300620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M url/url_canon_icu.h View 1 chunk +4 lines, -4 lines 0 comments Download
M url/url_canon_stdstring.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
viettrungluu
6 years, 2 months ago (2014-10-21 20:14:58 UTC) #1
brettw
lgtm
6 years, 2 months ago (2014-10-21 20:16:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658563010/1
6 years, 2 months ago (2014-10-21 21:05:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27939)
6 years, 2 months ago (2014-10-21 23:45:45 UTC) #6
viettrungluu
Committed patchset #1 (id:1) to pending queue manually as be226f0261e2cf4f63f9075ffacb247fdcabbc3e (presubmit successful).
6 years, 2 months ago (2014-10-22 02:27:24 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:05:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b424ebc2b0ea7c7cfc448c07d0375a49bb797d4d
Cr-Commit-Position: refs/heads/master@{#300620}

Powered by Google App Engine
This is Rietveld 408576698