Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 658563005: DevTools: [CodeMirror] roll comment plugin to @7dfbf42 (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [CodeMirror] roll comment plugin to @7dfbf42 BUG=414302 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/cm/comment.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
lushnikov
PTAL
6 years, 2 months ago (2014-10-20 16:14:05 UTC) #1
vsevik
lgtm
6 years, 2 months ago (2014-10-20 16:18:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658563005/1
6 years, 2 months ago (2014-10-20 16:19:10 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:22:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183998

Powered by Google App Engine
This is Rietveld 408576698