Better typing and type verification

src/compiler/js-graph.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-graph.h"
 #include "src/compiler/node-properties-inl.h"
 #include "src/compiler/typer.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 Node* JSGraph::ImmovableHeapConstant(Handle<HeapObject> object) {
   Unique<HeapObject> unique = Unique<HeapObject>::CreateImmovable(object);
-  return NewNode(common()->HeapConstant(unique));
+  return graph()->NewNode(common()->HeapConstant(unique));
 }
 
 
-Node* JSGraph::NewNode(const Operator* op) {
-  Node* node = graph()->NewNode(op);
-  typer_->Init(node);
-  return node;
-}
-
-
 Node* JSGraph::CEntryStubConstant() {
   if (!c_entry_stub_constant_.is_set()) {
     c_entry_stub_constant_.set(
         ImmovableHeapConstant(CEntryStub(isolate(), 1).GetCode()));
   }
   return c_entry_stub_constant_.get();
 }
 
 
 Node* JSGraph::UndefinedConstant() {
@@ skipping 52 matching lines @@
 Node* JSGraph::NaNConstant() {
   if (!nan_constant_.is_set()) {
     nan_constant_.set(NumberConstant(base::OS::nan_value()));
   }
   return nan_constant_.get();
 }
 
 
 Node* JSGraph::HeapConstant(Unique<HeapObject> value) {
   // TODO(turbofan): canonicalize heap constants using Unique<T>
-  return NewNode(common()->HeapConstant(value));
+  return graph()->NewNode(common()->HeapConstant(value));
 }
 
 
 Node* JSGraph::HeapConstant(Handle<HeapObject> value) {
   // TODO(titzer): We could also match against the addresses of immortable
   // immovables here, even without access to the heap, thus always
   // canonicalizing references to them.
   // return HeapConstant(Unique<Object>::CreateUninitialized(value));
   // TODO(turbofan): This is a work-around to make Unique::HashCode() work for
   // value numbering. We need some sane way to compute a unique hash code for
@@ skipping 35 matching lines @@
 Node* JSGraph::Constant(int32_t value) {
   if (value == 0) return ZeroConstant();
   if (value == 1) return OneConstant();
   return NumberConstant(value);
 }
 
 
 Node* JSGraph::Int32Constant(int32_t value) {
   Node** loc = cache_.FindInt32Constant(value);
   if (*loc == NULL) {
-    *loc = NewNode(common()->Int32Constant(value));
+    *loc = graph()->NewNode(common()->Int32Constant(value));
   }
   return *loc;
 }
 
 
 Node* JSGraph::Int64Constant(int64_t value) {
   Node** loc = cache_.FindInt64Constant(value);
   if (*loc == NULL) {
-    *loc = NewNode(common()->Int64Constant(value));
+    *loc = graph()->NewNode(common()->Int64Constant(value));
   }
   return *loc;
 }
 
 
 Node* JSGraph::NumberConstant(double value) {
   Node** loc = cache_.FindNumberConstant(value);
   if (*loc == NULL) {
-    *loc = NewNode(common()->NumberConstant(value));
+    *loc = graph()->NewNode(common()->NumberConstant(value));
   }
   return *loc;
 }
 
 
 Node* JSGraph::Float32Constant(float value) {
   // TODO(turbofan): cache float32 constants.
-  return NewNode(common()->Float32Constant(value));
+  return graph()->NewNode(common()->Float32Constant(value));
 }
 
 
 Node* JSGraph::Float64Constant(double value) {
   Node** loc = cache_.FindFloat64Constant(value);
   if (*loc == NULL) {
-    *loc = NewNode(common()->Float64Constant(value));
+    *loc = graph()->NewNode(common()->Float64Constant(value));
   }
   return *loc;
 }
 
 
 Node* JSGraph::ExternalConstant(ExternalReference reference) {
   Node** loc = cache_.FindExternalConstant(reference);
   if (*loc == NULL) {
-    *loc = NewNode(common()->ExternalConstant(reference));
+    *loc = graph()->NewNode(common()->ExternalConstant(reference));
   }
   return *loc;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8